Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CI and full size test #112

Merged
merged 1 commit into from
Jun 16, 2022
Merged

update CI and full size test #112

merged 1 commit into from
Jun 16, 2022

Conversation

ggabernet
Copy link
Member

  • Update full size tests to use Ensembl reference
  • Update CI tests to use stub run for cellranger count

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ggabernet ggabernet mentioned this pull request Jun 16, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ec6628f

+| ✅ 147 tests passed       |+
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.0.0'
  • readme - README did not have a Nextflow minimum version badge.

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-16 12:46:41

fmalmeida
fmalmeida approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@fmalmeida fmalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ggabernet ggabernet merged commit 3698303 into nf-core:dev Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalmeida fmalmeida fmalmeida approved these changes

@apeltzer apeltzer Awaiting requested review from apeltzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @fmalmeida